Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2806038: gyp: update to r836 (Closed)

Created:
10 years, 5 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

gyp: update to r836 Includes following changes. ------------------------------------------------------------------------ r836 | evan@chromium.org | 2010-06-30 17:09:33 -0700 (Wed, 30 Jun 2010) | 2 lines Fix previous patch, TBR. ------------------------------------------------------------------------ r835 | evan@chromium.org | 2010-06-30 16:04:37 -0700 (Wed, 30 Jun 2010) | 2 lines Temporarily turn off ARFLAGS detection to work around a gold bug. Review URL: http://codereview.chromium.org/2870040 ------------------------------------------------------------------------ r834 | evan@chromium.org | 2010-06-29 13:58:08 -0700 (Tue, 29 Jun 2010) | 6 lines Don't use ranlib, use ar's "s" flag instead. Patch by Shinichiro Hamaji <hamaji@chromium.org>;. Review URL: http://codereview.chromium.org/2800033 ------------------------------------------------------------------------ r833 | mark@chromium.org | 2010-06-28 13:15:06 -0700 (Mon, 28 Jun 2010) | 5 lines Xcode support for already-assembled .o (object) files as sources. BUG=gyp:157 TEST=none Review URL: http://codereview.chromium.org/2878002 ------------------------------------------------------------------------ r832 | evan@chromium.org | 2010-06-25 10:46:11 -0700 (Fri, 25 Jun 2010) | 30 lines Use GNU ar's thin archive if this feature is available. The thin archives don't have actual copy of object files. Instead, they have the paths to object files like symbolic links. With this option, ar and ranlib in chromium build become much faster on linux. Before this change: Total size of .a files: 1726537946 (1726M) ./ar.sh 8.73s user 12.28s system 26% cpu 1:19.24 total ./link.sh 9.14s user 4.54s system 14% cpu 1:36.01 total After this change: Total size of .a files: 43157870 (43M) ./ar.sh 7.77s user 1.75s system 97% cpu 9.797 total ./link.sh 9.10s user 5.26s system 21% cpu 1:06.18 total I'm not sure why link also becomes faster. Maybe other processes were running when I ran link.sh. The link.sh just links chrome and the ar.sh is generated by grepping our build process. The actual file is here: http://shinh.skr.jp/t/ar.sh.txt Unfortunately, this feature is relatively new (2008-03-27, http://sourceware.org/ml/binutils/2008-03/msg00150.html), so I think we cannot expect everyone have this feature. So we autodetect it at build time. Code review: http://codereview.chromium.org/2841004 ------------------------------------------------------------------------ r831 | mark@chromium.org | 2010-06-24 09:44:51 -0700 (Thu, 24 Jun 2010) | 5 lines Make loadable_modules without mac_bundle buildable. BUG=none TEST=none Review URL: http://codereview.chromium.org/2859021 ------------------------------------------------------------------------ r830 | stuartmorgan@chromium.org | 2010-06-23 08:01:31 -0700 (Wed, 23 Jun 2010) | 1 line Add support for target-level Xcode config files. Review URL: http://codereview.appspot.com/1687044/show ------------------------------------------------------------------------ r827 | thestig@chromium.org | 2010-05-21 18:44:01 -0700 (Fri, 21 May 2010) | 5 lines Raise an error when a configuration dictionary contains invalid keys. BUG=none TEST=included Review URL: http://codereview.chromium.org/2094021 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51195 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51310

Patch Set 1 #

Patch Set 2 : 833 #

Patch Set 3 : 834 #

Patch Set 4 : ok #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Martin
FYI, gonna roll in your recent gyp change in a sec. Running through trybots in ...
10 years, 5 months ago (2010-06-28 21:36:41 UTC) #1
Mark Mentovai
Can you roll to 833 instead? That’s current.
10 years, 5 months ago (2010-06-28 21:41:04 UTC) #2
Lei Zhang
We need to roll deps for NACL to r2565+ first. See http://crbug.com/45067
10 years, 5 months ago (2010-06-28 21:45:03 UTC) #3
Evan Martin
On 2010/06/28 21:45:03, Lei Zhang wrote: > We need to roll deps for NACL to ...
10 years, 5 months ago (2010-06-28 21:46:01 UTC) #4
Lei Zhang
Brad rolls deps for NACL, so we're good for r827.
10 years, 5 months ago (2010-06-29 20:39:38 UTC) #5
Evan Martin
Trying again with r833...
10 years, 5 months ago (2010-06-29 21:34:36 UTC) #6
Evan Martin
On 2010/06/29 21:34:36, Evan Martin wrote: > Trying again with r833... Er, 834.
10 years, 5 months ago (2010-06-29 21:36:16 UTC) #7
Mark Mentovai
LGTM
10 years, 5 months ago (2010-06-29 21:43:58 UTC) #8
Evan Martin
On 2010/06/29 21:43:58, Mark Mentovai wrote: > LGTM Had to revert part of hamaji's work. ...
10 years, 5 months ago (2010-07-01 00:18:21 UTC) #9
Mark Mentovai
10 years, 5 months ago (2010-07-01 01:07:41 UTC) #10
Yes, that’s thestig, and it seems like it found a real error in base.gyp.

Powered by Google App Engine
This is Rietveld 408576698