Raise an error when a configuration dictionary contains invalid keys....

Raise an error when a configuration dictionary contains invalid keys.

BUG=none
TEST=included

Committed: http://code.google.com/p/gyp/source/detail?r=827

[Lei Zhang, 2010-05-21 20:36:45]

http://code.google.com/p/gyp/wiki/GypLanguageSpecification says:

"A configuration dictionary may contain anything that can be found within a
target dictionary, except for actions, all_dependent_settings, configurations,
dependencies, direct_dependent_settings, libraries, link_settings, sources,
target_name, and type."

We should raise an error when this happens to alert the .gyp file writer that
Gyp is not going to do what they think Gyp should do.

[Mark Mentovai, 2010-05-21 21:12:13]

lgo

http://codereview.chromium.org/2094021/diff/1/2
File pylib/gyp/input.py (right):

http://codereview.chromium.org/2094021/diff/1/2#newcode1806
pylib/gyp/input.py:1806: raise KeyError, ('%s are not allowed in the %s
configuration'
"are" being correct depends on the value of |key|. Most keys that will show up
here are plural, but target_name and type are not, and there’s no guarantee
about future ones. I’d just leave the verb out. Also, I’d include the value of
target for debugging purposes. '%s not allowed in configuration %s, found in
target %s' % (key, configuration, target).

http://codereview.chromium.org/2094021/diff/1/4
File test/configurations/invalid/all_dependent_settings.gyp (right):

http://codereview.chromium.org/2094021/diff/1/4#newcode9
test/configurations/invalid/all_dependent_settings.gyp:9: 'type': 'executable',
These are all invalid for other reasons: they’re executables without sources.
Make it so that they would all be valid were it not for the bogus key in their
configuration dicts. Maybe just declare them as 'type': 'none'.

[Mark Mentovai, 2010-05-21 21:12:26]

P.S. great idea!

[Lei Zhang, 2010-05-22 01:21:21]

http://codereview.chromium.org/2094021/diff/1/2
File pylib/gyp/input.py (right):

http://codereview.chromium.org/2094021/diff/1/2#newcode1806
pylib/gyp/input.py:1806: raise KeyError, ('%s are not allowed in the %s
configuration'
On 2010/05/21 21:12:13, Mark Mentovai wrote:
> "are" being correct depends on the value of |key|. Most keys that will show up
> here are plural, but target_name and type are not, and there’s no guarantee
> about future ones. I’d just leave the verb out. Also, I’d include the value of
> target for debugging purposes. '%s not allowed in configuration %s, found in
> target %s' % (key, configuration, target).

Done. As you may have guessed, I started with "actions".

http://codereview.chromium.org/2094021/diff/1/4
File test/configurations/invalid/all_dependent_settings.gyp (right):

http://codereview.chromium.org/2094021/diff/1/4#newcode9
test/configurations/invalid/all_dependent_settings.gyp:9: 'type': 'executable',
On 2010/05/21 21:12:13, Mark Mentovai wrote:
> These are all invalid for other reasons: they’re executables without sources.
> Make it so that they would all be valid were it not for the bogus key in their
> configuration dicts. Maybe just declare them as 'type': 'none'.

Done.