Issue 2859021: Make loadable_modules without mac_bundle buildable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859021: Make loadable_modules without mac_bundle buildable (Closed)

Created:
10 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL, bradn

CC:
gyp-developer_googlegroups.com, apatrick_chromium, bradnelson

Base URL:
http://gyp.googlecode.com/svn/

Visibility:
Public.

Description

Make loadable_modules without mac_bundle buildable. BUG=none TEST=none Committed: http://code.google.com/p/gyp/source/detail?r=831

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -20 lines)			Patch
	M	trunk/pylib/gyp/generator/xcode.py	View	1	2 chunks	+6 lines, -11 lines	0 comments	Download
	M	trunk/pylib/gyp/xcodeproj_file.py	View		2 chunks	+40 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

(Context and repro case: http://codereview.chromium.org/2850009/)

10 years, 6 months ago (2010-06-23 22:28:47 UTC) #2

TVL

10 years, 6 months ago (2010-06-24 12:40:40 UTC) #4

lgtm.

I believe the plugin injection lib might be one of the things that forced us to
get this initial support in, are these changes still good for it?

Expand Messages | Collapse Messages