Issue 2806020: Add a warning when git-cl-upload-hook is modified to update git-cl accordingly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806020: Add a warning when git-cl-upload-hook is modified to update git-cl accordingly. (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add a warning when git-cl-upload-hook is modified to update git-cl accordingly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50481

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 6 months ago (2010-06-22 17:49:53 UTC) #2

LGTM

I didn't realize you were talking about this PRESUBMIT.py. Thanks for taking
this one step further -- still not right fix, IMHO :-) but better.

PS. It seems this file may benefit from refactoring the common checks into a
separate routine.

Expand Messages | Collapse Messages