OLD | NEW |
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for depot tools. | 5 """Top-level presubmit script for depot tools. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
11 UNIT_TESTS = [ | 11 UNIT_TESTS = [ |
12 'tests.gcl_unittest', | 12 'tests.gcl_unittest', |
13 'tests.gclient_scm_test', | 13 'tests.gclient_scm_test', |
14 'tests.gclient_utils_test', | 14 'tests.gclient_utils_test', |
15 'tests.presubmit_unittest', | 15 'tests.presubmit_unittest', |
16 'tests.scm_unittest', | 16 'tests.scm_unittest', |
17 'tests.trychange_unittest', | 17 'tests.trychange_unittest', |
18 'tests.watchlists_unittest', | 18 'tests.watchlists_unittest', |
19 ] | 19 ] |
20 | 20 |
21 def CheckChangeOnUpload(input_api, output_api): | 21 def CheckChangeOnUpload(input_api, output_api): |
22 output = [] | 22 output = [] |
23 output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, | 23 output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, |
24 output_api, | 24 output_api, |
25 UNIT_TESTS)) | 25 UNIT_TESTS)) |
| 26 output.extend(WasGitClUploadHookModified(input_api, output_api)) |
26 return output | 27 return output |
27 | 28 |
28 | 29 |
29 def CheckChangeOnCommit(input_api, output_api): | 30 def CheckChangeOnCommit(input_api, output_api): |
30 output = [] | 31 output = [] |
31 output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, | 32 output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, |
32 output_api, | 33 output_api, |
33 UNIT_TESTS)) | 34 UNIT_TESTS)) |
34 output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api, | 35 output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api, |
35 output_api)) | 36 output_api)) |
| 37 output.extend(WasGitClUploadHookModified(input_api, output_api)) |
36 return output | 38 return output |
| 39 |
| 40 def WasGitClUploadHookModified(input_api, output_api): |
| 41 for affected_file in input_api.AffectedSourceFiles(None): |
| 42 if (input_api.os_path.basename(affected_file.LocalPath()) == |
| 43 'git-cl-upload-hook'): |
| 44 return [output_api.PresubmitPromptWarning( |
| 45 'Don\'t forget to fix git-cl to download the newest version of ' |
| 46 'git-cl-upload-hook')] |
| 47 return [] |
OLD | NEW |