Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: PRESUBMIT.py

Issue 2806020: Add a warning when git-cl-upload-hook is modified to update git-cl accordingly. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 59b25bd45a039aaa7942fe96175c7ee38c2033f5..f3a1b8c77e8a4135c0b87004f217f0a1143e9b8d 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -23,6 +23,7 @@ def CheckChangeOnUpload(input_api, output_api):
output.extend(input_api.canned_checks.RunPythonUnitTests(input_api,
output_api,
UNIT_TESTS))
+ output.extend(WasGitClUploadHookModified(input_api, output_api))
return output
@@ -33,4 +34,14 @@ def CheckChangeOnCommit(input_api, output_api):
UNIT_TESTS))
output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api,
output_api))
+ output.extend(WasGitClUploadHookModified(input_api, output_api))
return output
+
+def WasGitClUploadHookModified(input_api, output_api):
+ for affected_file in input_api.AffectedSourceFiles(None):
+ if (input_api.os_path.basename(affected_file.LocalPath()) ==
+ 'git-cl-upload-hook'):
+ return [output_api.PresubmitPromptWarning(
+ 'Don\'t forget to fix git-cl to download the newest version of '
+ 'git-cl-upload-hook')]
+ return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698