Issue 2805026: Clang: Do not ignore result of HANDLE_EINTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2805026: Clang: Do not ignore result of HANDLE_EINTR. (Closed)

Created:
10 years, 6 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, jam+cc_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org

Visibility:
Public.

Description

Clang: Do not ignore result of HANDLE_EINTR. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50556

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -32 lines)			Patch
M	app/surface/transport_dib_mac.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	base/file_util.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	base/message_loop_unittest.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	base/message_pump_libevent.cc	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_helper.cc	View		2 chunks	+4 lines, -2 lines	1 comment	Download
M	ipc/file_descriptor_set_posix.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	ipc/ipc_channel_posix.cc	View		14 chunks	+34 lines, -17 lines	0 comments	Download
M	net/socket/tcp_client_socket_libevent.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 6 months ago (2010-06-22 23:09:59 UTC) #2

LGTM

http://codereview.chromium.org/2805026/diff/2001/3005
File chrome/browser/renderer_host/render_widget_helper.cc (right):

http://codereview.chromium.org/2805026/diff/2001/3005#newcode311
chrome/browser/renderer_host/render_widget_helper.cc:311: PLOG(ERROR) << "close:
" << i->first;
i->first or i->second here?  maybe make it clear it's the transport dib id
you're printing?

Expand Messages | Collapse Messages