Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1786)

Unified Diff: app/surface/transport_dib_mac.cc

Issue 2805026: Clang: Do not ignore result of HANDLE_EINTR. (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util.h » ('j') | chrome/browser/renderer_host/render_widget_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/surface/transport_dib_mac.cc
diff --git a/app/surface/transport_dib_mac.cc b/app/surface/transport_dib_mac.cc
index ef1d24251d675fd343edb60552be43dd8fde91da..f17835ff2fbc6e203cdf6fd7c8b979a74a0f2549 100644
--- a/app/surface/transport_dib_mac.cc
+++ b/app/surface/transport_dib_mac.cc
@@ -8,6 +8,7 @@
#include <sys/stat.h>
#include "base/eintr_wrapper.h"
+#include "base/logging.h"
#include "base/scoped_ptr.h"
#include "base/shared_memory.h"
#include "skia/ext/platform_canvas.h"
@@ -47,7 +48,8 @@ TransportDIB* TransportDIB::Map(TransportDIB::Handle handle) {
if ((fstat(handle.fd, &st) != 0) ||
(!dib->shared_memory_.Map(st.st_size))) {
delete dib;
- HANDLE_EINTR(close(handle.fd));
+ if (HANDLE_EINTR(close(handle.fd)) < 0)
+ PLOG(ERROR) << "close";
return NULL;
}
« no previous file with comments | « no previous file | base/file_util.h » ('j') | chrome/browser/renderer_host/render_widget_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698