net/socket/tcp_client_socket_libevent.cc - Issue 2805026: Clang: Do not ignore result of HANDLE_EINTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_libevent.cc

Issue 2805026: Clang: Do not ignore result of HANDLE_EINTR. (Closed)

Patch Set: '' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_client_socket_libevent.cc

diff --git a/net/socket/tcp_client_socket_libevent.cc b/net/socket/tcp_client_socket_libevent.cc

index 102a8fbc77cc875ab2a6a09c9ce8251a15d31a6d..802dcc9f5f625993cb563132a5af60d95b613e8c 100644

--- a/net/socket/tcp_client_socket_libevent.cc

+++ b/net/socket/tcp_client_socket_libevent.cc

@@ -256,7 +256,8 @@ void TCPClientSocketLibevent::DoDisconnect() {

DCHECK(ok);

ok = write_socket_watcher_.StopWatchingFileDescriptor();

DCHECK(ok);

- HANDLE_EINTR(close(socket_));

+ if (HANDLE_EINTR(close(socket_)) < 0)

+ PLOG(ERROR) << "close";

socket_ = kInvalidSocket;

}