Revert 48102 - this test is now failing again, roughly since r49188 landed. A...

Revert 48102 - this test is now failing again, apparently since r49188 landed. As it is not clear this test was enabled due to the functionality it test being required (indeed, the comment still states it is not), disabling it again to get the tree open.

Original description from reverted change r48102:
TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now appears
to be passing.

BUG=none
TEST=MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop

Patch by Doug Muir <dmuir@google.com>;.

Review URL: http://codereview.chromium.org/2077014

TBR=jhawkins@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49241

[Paweł Hajdan Jr., 2010-06-09 09:40:01]

Could you file a bug for this and capture (copy-paste) the failure logs to
that bug? Thanks!

On Wed, Jun 9, 2010 at 11:34, <joth@chromium.org> wrote:

> Reviewers: James Hawkins,
>
> Description:
> Revert 48102 - this test is now failing again, roughly since r49188 landed.
> As
> it is not clear this test was enabled due to the functionality it test
> being
> required (indeed, the comment still states it is not), disabling it again
> to get
> the tree open.
>
> Original description from reverted change r48102:
> TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now
> appears
> to be passing.
>
> BUG=none
> TEST=MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop
>
> Patch by Doug Muir <dmuir@google.com>.
>
> Review URL: http://codereview.chromium.org/2077014
>
> TBR=jhawkins@chromium.org
>
> Please review this at http://codereview.chromium.org/2789002/show
>
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/message_loop_unittest.cc
>
>
> Index: base/message_loop_unittest.cc
> ===================================================================
> --- base/message_loop_unittest.cc       (revision 49239)
> +++ base/message_loop_unittest.cc       (working copy)
> @@ -1492,11 +1492,12 @@
>
>  }  // namespace
>
> -TEST(MessageLoopTest, FileDescriptorWatcherOutlivesMessageLoop) {
> +TEST(MessageLoopTest, DISABLED_FileDescriptorWatcherOutlivesMessageLoop) {
>   // Simulate a MessageLoop that dies before an FileDescriptorWatcher.
>   // This could happen when people use the Singleton pattern or atexit.
>   // This is disabled for now because it fails (valgrind shows
>   // invalid reads), and it's not clear any code relies on this...
> +  // TODO(dkegel): enable if it turns out we rely on this
>
>   // Create a file descriptor.  Doesn't need to be readable or writable,
>   // as we don't need to actually get any notifications.
>
>
>