Revert 48102 - this test is now failing again, roughly since r49188 landed. A...

base/message_loop_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/platform_thread.h"
 #include "base/ref_counted.h"
 #include "base/thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 1474 matching lines @@
   virtual void OnFileCanWriteWithoutBlocking(int fd) {
     MessageLoop::current()->Quit();
   }
   virtual void OnFileCanReadWithoutBlocking(int fd) {
     MessageLoop::current()->Quit();
   }
 };
 
 }  // namespace
 
-TEST(MessageLoopTest, FileDescriptorWatcherOutlivesMessageLoop) {
+TEST(MessageLoopTest, DISABLED_FileDescriptorWatcherOutlivesMessageLoop) {
   // Simulate a MessageLoop that dies before an FileDescriptorWatcher.
   // This could happen when people use the Singleton pattern or atexit.
   // This is disabled for now because it fails (valgrind shows
   // invalid reads), and it's not clear any code relies on this...
+  // TODO(dkegel): enable if it turns out we rely on this
 
   // Create a file descriptor.  Doesn't need to be readable or writable,
   // as we don't need to actually get any notifications.
   // pipe() is just the easiest way to do it.
   int pipefds[2];
   int err = pipe(pipefds);
   ASSERT_TRUE(err == 0);
   int fd = pipefds[1];
   {
     // Arrange for controller to live longer than message loop.
@@ skipping 28 matching lines @@
       message_loop.WatchFileDescriptor(fd,
           true, MessageLoopForIO::WATCH_WRITE, &controller, &delegate);
       controller.StopWatchingFileDescriptor();
     }
   }
   close(pipefds[0]);
   close(pipefds[1]);
 }
 
 #endif  // defined(OS_POSIX)