Issue 2077014: TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now appears...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2077014: TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now appears... (Closed)

Created:
10 years, 7 months ago by dmuir

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

TTF: Re-enable the FileDescriptorWatcherOutlivesMessageLoop test as it now appears to be passing. BUG=none TEST=MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop Patch by Doug Muir <dmuir@google.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48102

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/message_loop_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM, please prepend TTF: http://codereview.chromium.org/2077014/diff/1/2 File base/message_loop_unittest.cc (right): http://codereview.chromium.org/2077014/diff/1/2#newcode1497 base/message_loop_unittest.cc:1497: // TODO(dkegel): enable if it ...

10 years, 7 months ago (2010-05-20 22:46:07 UTC) #1

Patch Set 2 removes the TODO.

Expand Messages | Collapse Messages