Issue 2767001: Don't use disabled (gray) state for the language indicator.

Issue 2767001: Don't use disabled (gray) state for the language indicator. (Closed)

Created:
10 years, 6 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Don't use disabled (gray) state for the language indicator. BUG=chromium-os:3683 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49366

Patch Set 2 : fixed all #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -48 lines)			Patch
M	chrome/browser/chromeos/cros/language_library.h	View		5 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/cros/language_library.cc	View		3 chunks	+3 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_language_library.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.cc	View		2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

http://codereview.chromium.org/2767001/diff/1/3 File chrome/browser/chromeos/status/language_menu_button.h (right): http://codereview.chromium.org/2767001/diff/1/3#newcode55 chrome/browser/chromeos/status/language_menu_button.h:55: virtual void FocusChanged(LanguageLibrary* obj) {} Maybe you can get ...

10 years, 6 months ago (2010-06-09 05:20:31 UTC) #2

Yusuke Sato

10 years, 6 months ago (2010-06-09 09:35:09 UTC) #3

satorux1

10 years, 6 months ago (2010-06-09 09:39:17 UTC) #4

LGTM

On 2010/06/09 09:35:09, Yusuke Sato wrote:
> http://codereview.chromium.org/2767001/diff/1/3
> File chrome/browser/chromeos/status/language_menu_button.h (right):
> 
> http://codereview.chromium.org/2767001/diff/1/3#newcode55
> chrome/browser/chromeos/status/language_menu_button.h:55: virtual void
> FocusChanged(LanguageLibrary* obj) {}
> On 2010/06/09 05:20:32, satorux1 wrote:
> > Maybe you can get rid of FocusChanged() from the observer as well?
> 
> Done.

Expand Messages | Collapse Messages