Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: chrome/browser/chromeos/cros/language_library.cc

Issue 2767001: Don't use disabled (gray) state for the language indicator. (Closed)
Patch Set: fixed all Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/language_library.cc
diff --git a/chrome/browser/chromeos/cros/language_library.cc b/chrome/browser/chromeos/cros/language_library.cc
index de2485d31eb54746cbce5a7c1b0eba316fded83d..d1dc57c6129d06cd943e3e84480b7d5f899a080a 100644
--- a/chrome/browser/chromeos/cros/language_library.cc
+++ b/chrome/browser/chromeos/cros/language_library.cc
@@ -147,8 +147,7 @@ std::string LanguageLibrary::GetLanguageCodeFromDescriptor(
LanguageLibraryImpl::LanguageLibraryImpl()
: input_method_status_connection_(NULL),
- current_input_method_("", "", "", ""),
- is_focused_(false) {
+ current_input_method_("", "", "", "") {
scoped_ptr<InputMethodDescriptors> input_method_descriptors(
CreateFallbackInputMethodDescriptors());
current_input_method_ = input_method_descriptors->at(0);
@@ -300,9 +299,8 @@ void LanguageLibraryImpl::UpdatePropertyHandler(
// static
void LanguageLibraryImpl::FocusChangedHandler(void* object, bool is_focused) {
- LanguageLibraryImpl* language_library =
- static_cast<LanguageLibraryImpl*>(object);
- language_library->FocusChanged(is_focused);
+ // TODO(yusukes): Remove this function. Modify MonitorInputMethodStatuslibcros
+ // API as well.
}
bool LanguageLibraryImpl::EnsureStarted() {
@@ -380,17 +378,4 @@ void LanguageLibraryImpl::UpdateProperty(const ImePropertyList& prop_list) {
FOR_EACH_OBSERVER(Observer, observers_, ImePropertiesChanged(this));
}
-void LanguageLibraryImpl::FocusChanged(bool is_focused) {
- if (!ChromeThread::CurrentlyOn(ChromeThread::UI)) {
- ChromeThread::PostTask(
- ChromeThread::UI, FROM_HERE,
- NewRunnableMethod(
- this, &LanguageLibraryImpl::FocusChanged, is_focused));
- return;
- }
-
- is_focused_ = is_focused;
- FOR_EACH_OBSERVER(Observer, observers_, FocusChanged(this));
-}
-
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/cros/language_library.h ('k') | chrome/browser/chromeos/cros/mock_language_library.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698