Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3185)

Unified Diff: chrome/browser/chromeos/cros/language_library.h

Issue 2767001: Don't use disabled (gray) state for the language indicator. (Closed)
Patch Set: fixed all Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/language_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/language_library.h
diff --git a/chrome/browser/chromeos/cros/language_library.h b/chrome/browser/chromeos/cros/language_library.h
index 8c237959aadff3e8c248b60e41bba6b2368acfb9..4d90df59e46ba4a69d9a12e835315a2ba334ec0a 100644
--- a/chrome/browser/chromeos/cros/language_library.h
+++ b/chrome/browser/chromeos/cros/language_library.h
@@ -26,7 +26,6 @@ class LanguageLibrary {
virtual ~Observer() = 0;
virtual void InputMethodChanged(LanguageLibrary* obj) = 0;
virtual void ImePropertiesChanged(LanguageLibrary* obj) = 0;
- virtual void FocusChanged(LanguageLibrary* obj) = 0;
};
virtual ~LanguageLibrary() {}
@@ -80,7 +79,6 @@ class LanguageLibrary {
virtual const InputMethodDescriptor& current_input_method() const = 0;
virtual const ImePropertyList& current_ime_properties() const = 0;
- virtual bool is_focused() const = 0;
// Normalizes the language code and returns the normalized version. The
// function normalizes the given language code to be compatible with the
@@ -144,10 +142,6 @@ class LanguageLibraryImpl : public LanguageLibrary {
return current_ime_properties_;
}
- virtual bool is_focused() const {
- return is_focused_;
- }
-
private:
// This method is called when there's a change in input method status.
static void InputMethodChangedHandler(
@@ -187,9 +181,6 @@ class LanguageLibraryImpl : public LanguageLibrary {
// Called by the handler to update input method properties.
void UpdateProperty(const ImePropertyList& prop_list);
- // Called by the handler to notify focus changes.
- void FocusChanged(bool is_focused);
-
// Tries to send all pending SetImeConfig requests to the input method config
// daemon.
void FlushImeConfig();
@@ -206,9 +197,6 @@ class LanguageLibraryImpl : public LanguageLibrary {
// might be empty when no input method is used.
ImePropertyList current_ime_properties_;
- // true if a text input area in Chrome is focused.
- bool is_focused_;
-
typedef std::pair<std::string, std::string> ConfigKeyType;
typedef std::map<ConfigKeyType, ImeConfigValue> InputMethodConfigRequests;
// SetImeConfig requests that are not yet completed.
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/language_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698