Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3526)

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 275007: Update page action manifest parsing to match the new format. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.cc
diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc
index b269848afc2296a1dfc9a32faa6059b56125125d..db37ee50ce00a397fd1913a89d259c38dc7fd46c 100644
--- a/chrome/common/extensions/extension_constants.cc
+++ b/chrome/common/extensions/extension_constants.cc
@@ -18,8 +18,11 @@ const wchar_t* kJs = L"js";
const wchar_t* kMatches = L"matches";
const wchar_t* kName = L"name";
const wchar_t* kPageActionId = L"id";
+const wchar_t* kPageAction = L"page_action";
const wchar_t* kPageActions = L"page_actions";
const wchar_t* kPageActionIcons = L"icons";
+const wchar_t* kPageActionDefaultIcon = L"default_icon";
+const wchar_t* kPageActionDefaultTitle = L"default_title";
const wchar_t* kPageActionPopup = L"popup";
const wchar_t* kPageActionPopupHeight = L"height";
const wchar_t* kPageActionPopupPath = L"path";
@@ -93,15 +96,17 @@ const char* kInvalidMatches =
const char* kInvalidName =
"Required value 'name' is missing or invalid.";
const char* kInvalidPageAction =
- "Invalid value for 'page_actions[*]'.";
+ "Invalid value for 'page_action'.";
const char* kInvalidPageActionIconPath =
- "Invalid value for 'page_actions[*].icons[*]'.";
+ "Invalid value for 'page_action.default_icon'.";
const char* kInvalidPageActionsList =
"Invalid value for 'page_actions'.";
-const char* kInvalidPageActionIconPaths =
- "Required value 'page_actions[*].icons' is missing or invalid.";
+const char* kInvalidPageActionsListSize =
+ "Invalid value for 'page_actions'. There can be only one.";
const char* kInvalidPageActionId =
"Required value 'id' is missing or invalid.";
+const char* kInvalidPageActionDefaultTitle =
+ "Required value 'default_title' is missing or invalid.";
const char* kInvalidPageActionPopup =
"Invalid type for page action popup.";
const char* kInvalidPageActionPopupHeight =
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698