Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4539)

Unified Diff: chrome/common/extensions/extension_constants.h

Issue 275007: Update page action manifest parsing to match the new format. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_action.h ('k') | chrome/common/extensions/extension_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.h
diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index 61f80928833c89da1730286a1d1481c42838adac..1282995be6642f914c84aacc3ddbb2773bc64dca 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -19,8 +19,11 @@ namespace extension_manifest_keys {
extern const wchar_t* kMatches;
extern const wchar_t* kName;
extern const wchar_t* kPageActionId;
+ extern const wchar_t* kPageAction;
extern const wchar_t* kPageActions;
extern const wchar_t* kPageActionIcons;
+ extern const wchar_t* kPageActionDefaultIcon;
+ extern const wchar_t* kPageActionDefaultTitle;
extern const wchar_t* kPageActionPopup;
extern const wchar_t* kPageActionPopupHeight;
extern const wchar_t* kPageActionPopupPath;
@@ -87,9 +90,10 @@ namespace extension_manifest_errors {
extern const char* kInvalidVersion;
extern const char* kInvalidPageAction;
extern const char* kInvalidPageActionsList;
+ extern const char* kInvalidPageActionsListSize;
extern const char* kInvalidPageActionIconPath;
- extern const char* kInvalidPageActionIconPaths;
extern const char* kInvalidPageActionId;
+ extern const char* kInvalidPageActionDefaultTitle;
extern const char* kInvalidPageActionPopup;
extern const char* kInvalidPageActionPopupHeight;
extern const char* kInvalidPageActionPopupPath;
« no previous file with comments | « chrome/common/extensions/extension_action.h ('k') | chrome/common/extensions/extension_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698