Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/common/extensions/extension_constants.cc

Issue 275007: Update page action manifest parsing to match the new format. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_constants.h" 5 #include "chrome/common/extensions/extension_constants.h"
6 6
7 namespace extension_manifest_keys { 7 namespace extension_manifest_keys {
8 8
9 const wchar_t* kBackground = L"background_page"; 9 const wchar_t* kBackground = L"background_page";
10 const wchar_t* kBrowserAction = L"browser_action"; 10 const wchar_t* kBrowserAction = L"browser_action";
11 const wchar_t* kChromeURLOverrides = L"chrome_url_overrides"; 11 const wchar_t* kChromeURLOverrides = L"chrome_url_overrides";
12 const wchar_t* kContentScripts = L"content_scripts"; 12 const wchar_t* kContentScripts = L"content_scripts";
13 const wchar_t* kCss = L"css"; 13 const wchar_t* kCss = L"css";
14 const wchar_t* kDefaultLocale = L"default_locale"; 14 const wchar_t* kDefaultLocale = L"default_locale";
15 const wchar_t* kDescription = L"description"; 15 const wchar_t* kDescription = L"description";
16 const wchar_t* kIcons = L"icons"; 16 const wchar_t* kIcons = L"icons";
17 const wchar_t* kJs = L"js"; 17 const wchar_t* kJs = L"js";
18 const wchar_t* kMatches = L"matches"; 18 const wchar_t* kMatches = L"matches";
19 const wchar_t* kName = L"name"; 19 const wchar_t* kName = L"name";
20 const wchar_t* kPageActionId = L"id"; 20 const wchar_t* kPageActionId = L"id";
21 const wchar_t* kPageAction = L"page_action";
21 const wchar_t* kPageActions = L"page_actions"; 22 const wchar_t* kPageActions = L"page_actions";
22 const wchar_t* kPageActionIcons = L"icons"; 23 const wchar_t* kPageActionIcons = L"icons";
24 const wchar_t* kPageActionDefaultIcon = L"default_icon";
25 const wchar_t* kPageActionDefaultTitle = L"default_title";
23 const wchar_t* kPageActionPopup = L"popup"; 26 const wchar_t* kPageActionPopup = L"popup";
24 const wchar_t* kPageActionPopupHeight = L"height"; 27 const wchar_t* kPageActionPopupHeight = L"height";
25 const wchar_t* kPageActionPopupPath = L"path"; 28 const wchar_t* kPageActionPopupPath = L"path";
26 const wchar_t* kPermissions = L"permissions"; 29 const wchar_t* kPermissions = L"permissions";
27 const wchar_t* kPlugins = L"plugins"; 30 const wchar_t* kPlugins = L"plugins";
28 const wchar_t* kPluginsPath = L"path"; 31 const wchar_t* kPluginsPath = L"path";
29 const wchar_t* kPluginsPublic = L"public"; 32 const wchar_t* kPluginsPublic = L"public";
30 const wchar_t* kPrivacyBlacklists = L"privacy_blacklists"; 33 const wchar_t* kPrivacyBlacklists = L"privacy_blacklists";
31 const wchar_t* kPublicKey = L"key"; 34 const wchar_t* kPublicKey = L"key";
32 const wchar_t* kRunAt = L"run_at"; 35 const wchar_t* kRunAt = L"run_at";
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 const char* kInvalidMatchCount = 89 const char* kInvalidMatchCount =
87 "Invalid value for 'content_scripts[*].matches. There must be at least one " 90 "Invalid value for 'content_scripts[*].matches. There must be at least one "
88 "match specified."; 91 "match specified.";
89 const char* kInvalidMatch = 92 const char* kInvalidMatch =
90 "Invalid value for 'content_scripts[*].matches[*]'."; 93 "Invalid value for 'content_scripts[*].matches[*]'.";
91 const char* kInvalidMatches = 94 const char* kInvalidMatches =
92 "Required value 'content_scripts[*].matches' is missing or invalid."; 95 "Required value 'content_scripts[*].matches' is missing or invalid.";
93 const char* kInvalidName = 96 const char* kInvalidName =
94 "Required value 'name' is missing or invalid."; 97 "Required value 'name' is missing or invalid.";
95 const char* kInvalidPageAction = 98 const char* kInvalidPageAction =
96 "Invalid value for 'page_actions[*]'."; 99 "Invalid value for 'page_action'.";
97 const char* kInvalidPageActionIconPath = 100 const char* kInvalidPageActionIconPath =
98 "Invalid value for 'page_actions[*].icons[*]'."; 101 "Invalid value for 'page_action.default_icon'.";
99 const char* kInvalidPageActionsList = 102 const char* kInvalidPageActionsList =
100 "Invalid value for 'page_actions'."; 103 "Invalid value for 'page_actions'.";
101 const char* kInvalidPageActionIconPaths = 104 const char* kInvalidPageActionsListSize =
102 "Required value 'page_actions[*].icons' is missing or invalid."; 105 "Invalid value for 'page_actions'. There can be only one.";
103 const char* kInvalidPageActionId = 106 const char* kInvalidPageActionId =
104 "Required value 'id' is missing or invalid."; 107 "Required value 'id' is missing or invalid.";
108 const char* kInvalidPageActionDefaultTitle =
109 "Required value 'default_title' is missing or invalid.";
105 const char* kInvalidPageActionPopup = 110 const char* kInvalidPageActionPopup =
106 "Invalid type for page action popup."; 111 "Invalid type for page action popup.";
107 const char* kInvalidPageActionPopupHeight = 112 const char* kInvalidPageActionPopupHeight =
108 "Invalid value for page action popup height [*]."; 113 "Invalid value for page action popup height [*].";
109 const char* kInvalidPageActionPopupPath = 114 const char* kInvalidPageActionPopupPath =
110 "Invalid value for page action popup path [*]."; 115 "Invalid value for page action popup path [*].";
111 const char* kInvalidPageActionTypeValue = 116 const char* kInvalidPageActionTypeValue =
112 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'."; 117 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'.";
113 const char* kInvalidPermissions = 118 const char* kInvalidPermissions =
114 "Required value 'permissions' is missing or invalid."; 119 "Required value 'permissions' is missing or invalid.";
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 "Invalid value for update url: '[*]'."; 167 "Invalid value for update url: '[*]'.";
163 const char* kInvalidDefaultLocale = 168 const char* kInvalidDefaultLocale =
164 "Invalid value for default locale - locale name must be a string."; 169 "Invalid value for default locale - locale name must be a string.";
165 const char* kThemesCannotContainExtensions = 170 const char* kThemesCannotContainExtensions =
166 "A theme cannot contain extensions code."; 171 "A theme cannot contain extensions code.";
167 const char* kLocalesNoDefaultLocaleSpecified = 172 const char* kLocalesNoDefaultLocaleSpecified =
168 "Localization used, but default_locale wasn't specified in the manifest."; 173 "Localization used, but default_locale wasn't specified in the manifest.";
169 const char* kLocalesNoValidLocaleNamesListed = 174 const char* kLocalesNoValidLocaleNamesListed =
170 "No valid locale name could be found in _locales directory."; 175 "No valid locale name could be found in _locales directory.";
171 } // namespace extension_manifest_errors 176 } // namespace extension_manifest_errors
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698