Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 2733009: Revert 49353 - sync: Store hard coded constants into its header file.... (Closed)

Created:
10 years, 6 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
tfarina
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, pam+watch_chromium.org, tim (not reviewing), idana
Visibility:
Public.

Description

Revert 49353 - sync: Store hard coded constants into its header file. (Note: This was a TODO for akalin). BUG=None TEST=trybots, and manually Review URL: http://codereview.chromium.org/2704002 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
D chrome/browser/sync/tools/sync_constants.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/sync/tools/sync_constants.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/tools/sync_tools.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
10 years, 6 months ago (2010-06-10 02:07:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698