Issue 2733009: Revert 49353 - sync: Store hard coded constants into its header file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2733009: Revert 49353 - sync: Store hard coded constants into its header file.... (Closed)

Created:
10 years, 6 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
tfarina

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, pam+watch_chromium.org, tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 49353 - sync: Store hard coded constants into its header file. (Note: This was a TODO for akalin). BUG=None TEST=trybots, and manually Review URL: http://codereview.chromium.org/2704002 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49357

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -38 lines)			Patch
D	chrome/browser/sync/tools/sync_constants.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/browser/sync/tools/sync_constants.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_tools.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)