Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7150)

Unified Diff: chrome/browser/sync/tools/sync_listen_notifications.cc

Issue 2733009: Revert 49353 - sync: Store hard coded constants into its header file.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/tools/sync_constants.cc ('k') | chrome/browser/sync/tools/sync_tools.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/tools/sync_listen_notifications.cc
===================================================================
--- chrome/browser/sync/tools/sync_listen_notifications.cc (revision 49356)
+++ chrome/browser/sync/tools/sync_listen_notifications.cc (working copy)
@@ -17,7 +17,6 @@
#include "base/task.h"
#include "chrome/browser/sync/notification_method.h"
#include "chrome/browser/sync/sync_constants.h"
-#include "chrome/browser/sync/tools/sync_constants.h"
#include "chrome/common/net/notifier/base/task_pump.h"
#include "chrome/common/net/notifier/communicator/xmpp_socket_adapter.h"
#include "chrome/common/net/notifier/listener/listen_task.h"
@@ -754,11 +753,13 @@
MessageLoopForIO message_loop;
// TODO(akalin): Make this configurable.
+ // TODO(akalin): Store these constants in a header somewhere (maybe
+ // browser/sync/protocol).
std::vector<std::string> data_types;
- data_types.push_back(sync_tools::kAutoFillType);
- data_types.push_back(sync_tools::kBookmarkType);
- data_types.push_back(sync_tools::kThemeType);
- data_types.push_back(sync_tools::kPreferenceType);
+ data_types.push_back("AUTOFILL");
+ data_types.push_back("BOOKMARK");
+ data_types.push_back("THEME");
+ data_types.push_back("PREFERENCE");
// Connect and listen.
LegacyNotifierDelegate legacy_notifier_delegate;
« no previous file with comments | « chrome/browser/sync/tools/sync_constants.cc ('k') | chrome/browser/sync/tools/sync_tools.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698