Issue 2704002: sync: Store hard coded constants into its header file.

Issue 2704002: sync: Store hard coded constants into its header file. (Closed)

Created:
10 years, 6 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

sync: Store hard coded constants into its header file. (Note: This was a TODO for akalin). BUG=None TEST=trybots, and manually

Patch Set 1 : fix namespace conflict #

Patch Set 2 : rebased to ToT #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -6 lines)			Patch
A	chrome/browser/sync/tools/sync_constants.h	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/tools/sync_constants.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_tools.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2010/06/07 15:56:45, tfarina wrote: > Hi Fred, could you review this to me? LGTM

10 years, 6 months ago (2010-06-08 21:09:54 UTC) #2

tfarina

On 2010/06/08 21:09:54, akalin wrote: > On 2010/06/07 15:56:45, tfarina wrote: > > Hi Fred, ...

10 years, 6 months ago (2010-06-10 05:28:01 UTC) #3

akalin

Since this change isn't in yet, it's probably best to abandon it. I'm doing some ...

10 years, 6 months ago (2010-06-15 18:57:39 UTC) #4

tfarina

10 years, 6 months ago (2010-06-15 22:14:58 UTC) #5

On 2010/06/15 18:57:39, akalin wrote:
> Since this change isn't in yet, it's probably best to abandon it.  I'm doing
> some refactoring of those tools and will be addressing that TODO.
For sure, I don't know why the Windows fails to link it. A bit weird I'd say,
and I didn't have time to investigate yet (so I'm closing it :/).

Expand Messages | Collapse Messages