Add concept of an options page to Extensions....

Add concept of an options page to Extensions.


BUG=23801
TEST=Create an extension with an "options_page" entry in its manifest with a value the name of a html file in the extension dir.
Load that extension and go to chrome://extensions, there should be an "Options" button that takes you to the page specified in the manifest.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29297

[Aaron Boodman, 2009-10-16 00:02:52]

http://codereview.chromium.org/271114/diff/1/8
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/271114/diff/1/8#newcode211
Line 211: if (!extension || extension->options_url().is_empty()) {
Can we make it so that the button does not show up at all if the extension does
not have a settings page?

http://codereview.chromium.org/271114/diff/1/5
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/271114/diff/1/5#newcode848
Line 848: options_str.empty()) {
In other places we don't consider an empty value for an optional key an error.
Better to be consistent.

[asargent_no_longer_on_chrome, 2009-10-16 00:52:02]

http://codereview.chromium.org/271114/diff/1/8
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/271114/diff/1/8#newcode211
Line 211: if (!extension || extension->options_url().is_empty()) {
On 2009/10/16 00:02:53, Aaron Boodman wrote:
> Can we make it so that the button does not show up at all if the extension
does
> not have a settings page?

Yes, one of the jstemplate properties I use on the button in extensions_ui.html

  jsdisplay="options_url"

keeps the button from being displayed in the first place for extensions with an
empty options url. The empty check here in the click message handler is just for
paranoia I guess, but maybe I should remove it to be clear the important
checking is happening elsewhere?

http://codereview.chromium.org/271114/diff/1/5
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/271114/diff/1/5#newcode848
Line 848: options_str.empty()) {
On 2009/10/16 00:02:53, Aaron Boodman wrote:
> In other places we don't consider an empty value for an optional key an error.
> Better to be consistent.

Ok. Done.

[Aaron Boodman, 2009-10-16 00:54:41]

lgtm

http://codereview.chromium.org/271114/diff/1/8
File chrome/browser/extensions/extensions_ui.cc (right):

http://codereview.chromium.org/271114/diff/1/8#newcode211
Line 211: if (!extension || extension->options_url().is_empty()) {
On 2009/10/16 00:52:02, Antony Sargent wrote:
> On 2009/10/16 00:02:53, Aaron Boodman wrote:
> > Can we make it so that the button does not show up at all if the extension
> does
> > not have a settings page?
> 
> Yes, one of the jstemplate properties I use on the button in
extensions_ui.html
> 
>   jsdisplay="options_url"
> 
> keeps the button from being displayed in the first place for extensions with
an
> empty options url. The empty check here in the click message handler is just
for
> paranoia I guess, but maybe I should remove it to be clear the important
> checking is happening elsewhere?
> 

Ah, ok. I think it is good to keep the check. The state of the extensions system
could conceivably change while the page is displayed.

[Paweł Hajdan Jr., 2009-10-16 05:21:12]

Drive-by, no need to wait for me after fixing it.

http://codereview.chromium.org/271114/diff/4001/4010
File chrome/browser/extensions/extension_browsertests_misc.cc (right):

http://codereview.chromium.org/271114/diff/4001/4010#newcode813
Line 813: EXPECT_EQ(1u, extensions->size());
Please use ASSERT here to prevent a crash in case of failure.

If you really want to use EXPECT here, please use ASSERT_LT(0u,
extensions->size()) before.

[Qamar165, 2013-02-27 06:03:42]

lgtm

[Qamar165, 2013-02-27 06:03:44]

lgtm