Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/resources/extensions_ui.html

Issue 271114: Add concept of an options page to Extensions.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions_ui.html
===================================================================
--- chrome/browser/resources/extensions_ui.html (revision 29288)
+++ chrome/browser/resources/extensions_ui.html (working copy)
@@ -206,6 +206,7 @@
"description": "Extension long format description",
"version": "1.0.231",
"enabled": "true",
+ "options_url": "options.html",
"content_scripts": [
{
"js": ["script1_file1.js", "script1_file2.js"],
@@ -345,12 +346,19 @@
}
/**
- * Utility function which asks the C++ to show a platform-specific file select
- * dialog, and fire |callback| with the |filePath| that resulted. |selectType|
- * can be either 'file' or 'folder'. |operation| can be 'load', 'packRoot',
- * or 'pem' which are signals to the C++ to do some operation-specific
- * configuration.
+ * Handles an 'options' button getting clicked.
*/
+function handleOptions(node) {
+ chrome.send('options', [node.extensionId]);
+}
+
+/**
+* Utility function which asks the C++ to show a platform-specific file select
+* dialog, and fire |callback| with the |filePath| that resulted. |selectType|
+* can be either 'file' or 'folder'. |operation| can be 'load', 'packRoot',
+* or 'pem' which are signals to the C++ to do some operation-specific
+* configuration.
+*/
function showFileDialog(selectType, operation, callback) {
handleFilePathSelected = function(filePath) {
callback(filePath);
@@ -387,7 +395,7 @@
/**
* Hides the pack dialog.
- */
+ */
function hidePackDialog() {
document.getElementById('dialogBackground').style.display="none"
}
@@ -438,7 +446,7 @@
<input type="text" id="extensionPathText">
</div>
<div>
- <input type="button" value="BROWSE"
+ <input type="button" value="BROWSE"
i18n-values="value:packDialogBrowse"
onclick="selectExtensionPath();">
</div>
@@ -451,7 +459,7 @@
<input type="text" id="privateKeyPath">
</div>
<div>
- <input type="button" value="BROWSE"
+ <input type="button" value="BROWSE"
i18n-values="value:packDialogBrowse"
onclick="selectPrivateKeyPath();">
</div>
@@ -463,7 +471,7 @@
<div>
<input type="button" value="Cancel" onclick="hidePackDialog();">
</div>
- </div>
+ </div>
</div>
</div>
</div>
@@ -524,6 +532,11 @@
jsvalues=".extensionId:id"
onclick="handleUninstallExtension(this)"
>Uninstall</button>
+ <button
+ jsdisplay="options_url"
+ jsvalues=".extensionId:id"
+ onclick="handleOptions(this)"
+ >Options</button>
</div>
</div>
</div>
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698