Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: chrome/common/extensions/extension.cc

Issue 271114: Add concept of an options page to Extensions.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc (revision 29288)
+++ chrome/common/extensions/extension.cc (working copy)
@@ -830,6 +830,16 @@
background_url_ = GetResourceURL(background_str);
}
+ // Initialize options page url (optional).
+ if (source.HasKey(keys::kOptionsPage)) {
+ std::string options_str;
+ if (!source.GetString(keys::kOptionsPage, &options_str)) {
+ *error = errors::kInvalidOptionsPage;
+ return false;
+ }
+ options_url_ = GetResourceURL(options_str);
+ }
+
// Initialize toolstrips (optional).
if (source.HasKey(keys::kToolstrips)) {
ListValue* list_value;
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698