Fix more GCC 4.3 warnings.

Fix more GCC 4.3 warnings.

[agl, 2009-02-22 01:25:35]

LGTM

http://codereview.chromium.org/27038/diff/1/2
File base/process_util_unittest.cc (right):

http://codereview.chromium.org/27038/diff/1/2#newcode184
Line 184: int written = write(write_pipe, &num_open_files,
sizeof(num_open_files));
ssize_t, not int

http://codereview.chromium.org/27038/diff/1/2#newcode185
Line 185: DCHECK(written == sizeof(num_open_files));
DCHECK_EQ

http://codereview.chromium.org/27038/diff/1/3
File webkit/tools/npapi_layout_test_plugin/PluginObject.cpp (right):

http://codereview.chromium.org/27038/diff/1/3#newcode560
Line 560: int written = fwrite(contentsString.UTF8Characters,
contentsString.UTF8Length, 1, tempFile);
size_t, not int

[Evan Martin, 2009-02-23 04:08:33]

On 2009/02/22 01:25:35, agl wrote:
> LGTM
> 
> http://codereview.chromium.org/27038/diff/1/2
> File base/process_util_unittest.cc (right):
> 
> http://codereview.chromium.org/27038/diff/1/2#newcode184
> Line 184: int written = write(write_pipe, &num_open_files,
> sizeof(num_open_files));
> ssize_t, not int
> 
> http://codereview.chromium.org/27038/diff/1/2#newcode185
> Line 185: DCHECK(written == sizeof(num_open_files));
> DCHECK_EQ
> 
> http://codereview.chromium.org/27038/diff/1/3
> File webkit/tools/npapi_layout_test_plugin/PluginObject.cpp (right):
> 
> http://codereview.chromium.org/27038/diff/1/3#newcode560
> Line 560: int written = fwrite(contentsString.UTF8Characters,
> contentsString.UTF8Length, 1, tempFile);
> size_t, not int

You had comments on 3 of my 6 lines, but it turns out the 4th one could be
improved as well (DCHECK_EQ).  Thanks for the review; you shoulda written it
yourself!  :P

[Evan Martin, 2009-02-23 04:27:41]

On 2009/02/23 04:08:33, Evan Martin wrote:
> On 2009/02/22 01:25:35, agl wrote:
> > LGTM
> > 
> > http://codereview.chromium.org/27038/diff/1/2
> > File base/process_util_unittest.cc (right):
> > 
> > http://codereview.chromium.org/27038/diff/1/2#newcode184
> > Line 184: int written = write(write_pipe, &num_open_files,
> > sizeof(num_open_files));
> > ssize_t, not int
> > 
> > http://codereview.chromium.org/27038/diff/1/2#newcode185
> > Line 185: DCHECK(written == sizeof(num_open_files));
> > DCHECK_EQ
> > 
> > http://codereview.chromium.org/27038/diff/1/3
> > File webkit/tools/npapi_layout_test_plugin/PluginObject.cpp (right):
> > 
> > http://codereview.chromium.org/27038/diff/1/3#newcode560
> > Line 560: int written = fwrite(contentsString.UTF8Characters,
> > contentsString.UTF8Length, 1, tempFile);
> > size_t, not int
> 
> You had comments on 3 of my 6 lines, but it turns out the 4th one could be
> improved as well (DCHECK_EQ).  Thanks for the review; you shoulda written it
> yourself!  :P

Windows doesn't have ssize_t.  Their fwrite is size_t and returns zero on error.
 :(