webkit/tools/npapi_layout_test_plugin/PluginObject.cpp - Issue 27038: Fix more GCC 4.3 warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/npapi_layout_test_plugin/PluginObject.cpp

Issue 27038: Fix more GCC 4.3 warnings. (Closed)

Patch Set: Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/npapi_layout_test_plugin/PluginObject.cpp

diff --git a/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp b/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp

index df8b40c3048b1ab359c976400c2d1e1412b62e8a..3df7c823bab4f0144fca7e1f8144cc7479bb1ab5 100644

--- a/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp

+++ b/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp

@@ -557,7 +557,8 @@ static bool testPostURLFile(PluginObject* obj, const NPVariant* args, uint32_t a

if (!tempFile)

return false;

- fwrite(contentsString.UTF8Characters, contentsString.UTF8Length, 1, tempFile);

+ int written = fwrite(contentsString.UTF8Characters, contentsString.UTF8Length, 1, tempFile);

agl 2009/02/22 01:25:35 size_t, not int

+ DCHECK(written == 1);

fclose(tempFile);

NPError error = browser->posturl(obj->npp, url, target, pathString.UTF8Length, path, TRUE);

« base/process_util_unittest.cc ('K') | « base/process_util_unittest.cc ('k') | no next file » | no next file with comments »