Fix more GCC 4.3 warnings.

base/process_util_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include "base/multiprocess_test.h"
 #include "base/platform_thread.h"
 #include "base/process_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 163 matching lines @@
   }
 
   // InitLogging always opens a file at startup.
   int expected_num_open_fds = 1;
 #if defined(OS_LINUX)
   // On Linux, '/etc/localtime' is opened before the test's main() enters.
   expected_num_open_fds += 1;
 #endif  // defined(OS_LINUX)
   num_open_files -= expected_num_open_fds;
 
-  write(write_pipe, &num_open_files, sizeof(num_open_files));
+  int written = write(write_pipe, &num_open_files, sizeof(num_open_files));

[agl, 2009/02/22 01:25:35]

ssize_t, not int

+  DCHECK(written == sizeof(num_open_files));

[agl, 2009/02/22 01:25:35]

DCHECK_EQ

   close(write_pipe);
 
   return 0;
 }
 
 TEST_F(ProcessUtilTest, FDRemapping) {
   // Open some files to check they don't get leaked to the child process.
   int fds[2];
-  pipe(fds);
+  if (pipe(fds) < 0)
+    NOTREACHED();
   int pipe_read_fd = fds[0];
   int pipe_write_fd = fds[1];
 
   // open some dummy fds to make sure they don't propogate over to the
   // child process.
   int dev_null = open("/dev/null", O_RDONLY);
   int sockets[2];
   socketpair(AF_UNIX, SOCK_STREAM, 0, sockets);
 
   file_handle_mapping_vector fd_mapping_vec;
@@ skipping 17 matching lines @@
   base::CloseProcessHandle(handle);
   close(fds[0]);
   close(sockets[0]);
   close(sockets[1]);
   close(dev_null);
 }
 
 #endif  // defined(OS_POSIX)
 
 }  // namespace base