Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 254012: gclient: fix unittests (Closed)

Created:
11 years, 2 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : removed dead code #

Patch Set 3 : Remove old code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M tests/gclient_test.py View 1 2 9 chunks +49 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mandeep Singh Baines
11 years, 2 months ago (2009-09-29 03:58:03 UTC) #1
msb
On Mon, Sep 28, 2009 at 7:37 PM, <thestig@chromium.org> wrote: > FYI, I think this ...
11 years, 2 months ago (2009-09-29 03:59:11 UTC) #2
M-A Ruel
11 years, 2 months ago (2009-09-29 13:24:30 UTC) #3
rubberstamp lgtm.

You need to fork git-cl and enable presubmit checks asap.

Powered by Google App Engine
This is Rietveld 408576698