Issue 248011: gclient: don't make SVN-specific calls in RunOnDeps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248011: gclient: don't make SVN-specific calls in RunOnDeps (Closed)

Created:
11 years, 3 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Marc-Antoine Ruel (Google), M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

gclient: don't make SVN-specific calls in RunOnDeps Replaced a call to CaptureSVNStatus with a SCMWrapper::status gclient: store gclient_entries as a dict Currently we only store the relative path for entries. We need to also store the url so that learn the repo type: git or snv. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27370

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	gclient.py	View		3 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 2 months ago (2009-09-29 02:37:23 UTC) #3

FYI, I think this broke a bunch of depot_tool unit tests.

Expand Messages | Collapse Messages