Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 249023: Use favicon for application shortcut icon. (Closed)

Created:
11 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com, brettw, ben+cc_chromium.org
Visibility:
Public.

Description

Use favicon for application shortcut icon. BUG=22528 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27422

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed unittests, handle null favicon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -18 lines) Patch
M chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h View 1 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/shell_integration.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 6 chunks +51 lines, -6 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 8 chunks +27 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
11 years, 2 months ago (2009-09-28 19:19:05 UTC) #1
Lei Zhang
Failed Linux trybot... http://codereview.chromium.org/249023/diff/1/3 File chrome/browser/shell_integration_linux.cc (right): http://codereview.chromium.org/249023/diff/1/3#newcode156 Line 156: argv.push_back("xdg-icon-resource"); Do we use chromium- ...
11 years, 2 months ago (2009-09-28 19:44:01 UTC) #2
Evan Stade
updated
11 years, 2 months ago (2009-09-28 20:23:34 UTC) #3
Lei Zhang
11 years, 2 months ago (2009-09-28 20:35:33 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698