Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6776)

Unified Diff: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h

Issue 249023: Use favicon for application shortcut icon. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fixed unittests, handle null favicon Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
===================================================================
--- chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (revision 27368)
+++ chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h (working copy)
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/string16.h"
#include "googleurl/src/gurl.h"
+#include "third_party/skia/include/core/SkBitmap.h"
typedef struct _GtkWidget GtkWidget;
typedef struct _GtkWindow GtkWindow;
@@ -16,11 +17,16 @@
public:
// Displays the dialog box to create application shortcuts for |url| with
// |title|.
- static void Show(GtkWindow* parent, const GURL& url, const string16& title);
+ static void Show(GtkWindow* parent,
+ const GURL& url,
+ const string16& title,
+ const SkBitmap& favicon);
private:
- CreateApplicationShortcutsDialogGtk(GtkWindow* parent, const GURL& url,
- const string16& title);
+ CreateApplicationShortcutsDialogGtk(GtkWindow* parent,
+ const GURL& url,
+ const string16& title,
+ const SkBitmap& favicon);
~CreateApplicationShortcutsDialogGtk() { }
// Handler to respond to Ok and Cancel responses from the dialog.
@@ -41,6 +47,9 @@
// Visible title of the shortcut.
string16 title_;
+ // The favicon of the tab contents, used to set the icon on the desktop.
+ SkBitmap favicon_;
+
DISALLOW_COPY_AND_ASSIGN(CreateApplicationShortcutsDialogGtk);
};
Property changes on: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « no previous file | chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698