Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5554)

Unified Diff: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc

Issue 249023: Use favicon for application shortcut icon. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fixed unittests, handle null favicon Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
===================================================================
--- chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc (revision 27368)
+++ chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc (working copy)
@@ -12,14 +12,19 @@
// static
void CreateApplicationShortcutsDialogGtk::Show(GtkWindow* parent,
const GURL& url,
- const string16& title) {
- new CreateApplicationShortcutsDialogGtk(parent, url, title);
+ const string16& title,
+ const SkBitmap& favicon) {
+ new CreateApplicationShortcutsDialogGtk(parent, url, title, favicon);
}
CreateApplicationShortcutsDialogGtk::CreateApplicationShortcutsDialogGtk(
- GtkWindow* parent, const GURL& url, const string16& title)
+ GtkWindow* parent,
+ const GURL& url,
+ const string16& title,
+ const SkBitmap& favicon)
: url_(url),
- title_(title) {
+ title_(title),
+ favicon_(favicon) {
// Build the dialog.
GtkWidget* dialog = gtk_dialog_new_with_buttons(
l10n_util::GetStringUTF8(IDS_CREATE_SHORTCUTS_TITLE).c_str(),
@@ -68,6 +73,7 @@
ShellIntegration::ShortcutInfo shortcut_info;
shortcut_info.url = url_;
shortcut_info.title = title_;
+ shortcut_info.favicon = favicon_;
shortcut_info.create_on_desktop =
gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(desktop_checkbox_));
shortcut_info.create_in_applications_menu =
Property changes on: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h ('k') | chrome/browser/shell_integration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698