Issue 244028: Check RegisterWaitForSingleObject return in CrashGenerationServer::Start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 244028: Check RegisterWaitForSingleObject return in CrashGenerationServer::Start. (Closed)

Created:
11 years, 2 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Check RegisterWaitForSingleObject return in CrashGenerationServer::Start. Breakpad r402

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	client/windows/crash_generation/crash_generation_server.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Mentovai

LGTM. Would you like me to check this into Breakpad for you?

11 years, 2 months ago (2009-09-28 23:40:56 UTC) #2

mattm

Yes, please. On Mon, Sep 28, 2009 at 16:40, <mark@chromium.org> wrote: > LGTM. =A0Would you ...

11 years, 2 months ago (2009-09-28 23:51:41 UTC) #3

Mark Mentovai

11 years, 2 months ago (2009-09-28 23:54:06 UTC) #4

Committed Breakpad r402.  You can update it in Chromium's DEPS now if you want.