client/windows/crash_generation/crash_generation_server.cc - Issue 244028: Check RegisterWaitForSingleObject return in CrashGenerationServer::Start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/windows/crash_generation/crash_generation_server.cc

Issue 244028: Check RegisterWaitForSingleObject return in CrashGenerationServer::Start. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/windows/crash_generation/crash_generation_server.cc

===================================================================

--- client/windows/crash_generation/crash_generation_server.cc (revision 391)

+++ client/windows/crash_generation/crash_generation_server.cc (working copy)

@@ -218,12 +218,14 @@

}

// Register a callback with the thread pool for the client connection.

- RegisterWaitForSingleObject(&pipe_wait_handle_,

- overlapped_.hEvent,

- OnPipeConnected,

- this,

- INFINITE,

- kPipeIOThreadFlags);

+ if (!RegisterWaitForSingleObject(&pipe_wait_handle_,

+ overlapped_.hEvent,

+ OnPipeConnected,

+ this,

+ INFINITE,

+ kPipeIOThreadFlags)) {

+ return false;

+ }

pipe_ = CreateNamedPipe(pipe_name_.c_str(),

kPipeAttr,

« no previous file with comments | « no previous file | no next file » | no next file with comments »