Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243076: Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classes... (Closed)

Created:
11 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ncarter (slow), Paul Godavari, ben+cc_chromium.org, Erik does not do reviews, idana, jam, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classes into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+498 lines, -1979 lines) Patch
M app/app.gyp View 1 3 chunks +12 lines, -0 lines 0 comments Download
A app/gfx/codec/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + app/gfx/codec/jpeg_codec.h View 2 chunks +8 lines, -4 lines 0 comments Download
A + app/gfx/codec/jpeg_codec.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + app/gfx/codec/jpeg_codec_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + app/gfx/codec/png_codec.h View 5 chunks +45 lines, -12 lines 0 comments Download
A + app/gfx/codec/png_codec.cc View 11 chunks +220 lines, -20 lines 0 comments Download
A + app/gfx/codec/png_codec_unittest.cc View 9 chunks +34 lines, -32 lines 0 comments Download
M app/resource_bundle.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M base/base.gyp View 1 3 chunks +0 lines, -11 lines 0 comments Download
M base/gfx/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
D base/gfx/jpeg_codec.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
D base/gfx/jpeg_codec.cc View 1 1 chunk +0 lines, -527 lines 0 comments Download
D base/gfx/jpeg_codec_unittest.cc View 1 1 chunk +0 lines, -147 lines 0 comments Download
D base/gfx/png_codec_unittest.cc View 1 1 chunk +0 lines, -249 lines 0 comments Download
D base/gfx/png_decoder.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
D base/gfx/png_decoder.cc View 1 1 chunk +0 lines, -377 lines 0 comments Download
D base/gfx/png_encoder.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
D base/gfx/png_encoder.cc View 1 1 chunk +0 lines, -240 lines 0 comments Download
M build/common.gypi View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_theme_provider.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_thumbnail_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/fileicon_source.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/fav_icon_helper.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/gears_integration.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/list_store_favicon_loader.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/thumbnail_database_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/icon_loader_linux.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/possible_url_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_table_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/thumbnail_store.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/thumbnail_store_unittest.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/security_filter_peer.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_view_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M printing/image.cc View 1 3 chunks +11 lines, -12 lines 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M tools/imagediff/image_diff.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M tools/imagediff/image_diff.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M views/widget/root_view.cc View 1 1 chunk +17 lines, -17 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 4 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
11 years, 2 months ago (2009-10-02 17:58:20 UTC) #1
Ben Goodger (Google)
LGTM.
11 years, 2 months ago (2009-10-02 18:16:31 UTC) #2
Evan Martin
11 years, 1 month ago (2009-10-27 21:12:28 UTC) #3 
http://codereview.chromium.org/243076/diff/5058/5119
File build/common.gypi (right):

http://codereview.chromium.org/243076/diff/5058/5119#newcode459
Line 459: #'-fno-rtti',
Why did you comment this out?

Powered by Google App Engine
This is Rietveld 408576698