Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: src/platform/vboot_reference/vfirmware/firmware_image.c

Issue 2353001: random cleanup (Closed) Base URL: ssh://git@chromiumos-git/chromeos
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/vfirmware/firmware_image.c
diff --git a/src/platform/vboot_reference/vfirmware/firmware_image.c b/src/platform/vboot_reference/vfirmware/firmware_image.c
index f4c31ad2db399a3ccb12e91e5afa6acc4f42f823..ba55d0a18f00fe21d5a941a09f4cc4a65ad4f29f 100644
--- a/src/platform/vboot_reference/vfirmware/firmware_image.c
+++ b/src/platform/vboot_reference/vfirmware/firmware_image.c
@@ -257,7 +257,7 @@ uint8_t* GetFirmwareBlob(const FirmwareImage* image, uint64_t* blob_len) {
return firmware_blob;
}
-int WriteFirmwareImage(const char* input_file,
+int WriteFirmwareImage(const char* output_file,
const FirmwareImage* image,
int is_only_vblock) {
int fd;
@@ -267,7 +267,7 @@ int WriteFirmwareImage(const char* input_file,
if (!image)
return 0;
- if (-1 == (fd = creat(input_file, S_IRWXU))) {
+ if (-1 == (fd = creat(output_file, 0666))) {
debug("Couldn't open file for writing.\n");
return 0;
}
@@ -279,7 +279,7 @@ int WriteFirmwareImage(const char* input_file,
}
if (!is_only_vblock) {
if (blob_len != write(fd, firmware_blob, blob_len)) {
- debug("Couldn't write Firmware Image to file: %s\n", input_file);
+ debug("Couldn't write Firmware Image to file: %s\n", output_file);
success = 0;
}
} else {
@@ -287,7 +287,7 @@ int WriteFirmwareImage(const char* input_file,
int vblock_len = blob_len - image->firmware_len;
if (vblock_len != write(fd, firmware_blob, vblock_len)) {
debug("Couldn't write Firmware Image verifcation block to file: %s\n",
- input_file);
+ output_file);
success = 0;
}
}
« no previous file with comments | « src/platform/vboot_reference/utility/firmware_utility.cc ('k') | src/platform/vboot_reference/vkernel/kernel_image.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698