src/platform/vboot_reference/utility/firmware_utility.cc - Issue 2353001: random cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/vboot_reference/utility/firmware_utility.cc

Issue 2353001: random cleanup (Closed) Base URL: ssh://git@chromiumos-git/chromeos

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform/vboot_reference/utility/firmware_utility.cc

diff --git a/src/platform/vboot_reference/utility/firmware_utility.cc b/src/platform/vboot_reference/utility/firmware_utility.cc

index 8ec654eb04f8600062af69b00fd124a433706d89..d5edf145df1d96774ccefb286090f2fd877fa8de 100644

--- a/src/platform/vboot_reference/utility/firmware_utility.cc

+++ b/src/platform/vboot_reference/utility/firmware_utility.cc

@@ -203,7 +203,7 @@ bool FirmwareUtility::GenerateSignedImage(void) {

Memset(image_->preamble, 'P', FIRMWARE_PREAMBLE_SIZE);

image_->firmware_data = BufferFromFile(in_file_.c_str(),

&image_->firmware_len);

- if (!image_)

+ if (!image_->firmware_data)

return false;

// Generate and add the signatures.

if (!AddFirmwareKeySignature(image_, root_key_file_.c_str())) {