random cleanup

src/platform/vboot_reference/vfirmware/firmware_image.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  *
  * Functions for generating and manipulating a verified boot firmware image.
  */
 
 #include "firmware_image.h"
 
 #include <sys/types.h>
@@ skipping 239 matching lines @@
   Free(preamble_blob);
   Free(header_blob);
 
   if (st.overrun || st.remaining_len != 0) { /* Underrun or Overrun. */
     Free(firmware_blob);
     return NULL;
   }
   return firmware_blob;
 }
 
-int WriteFirmwareImage(const char* input_file,
+int WriteFirmwareImage(const char* output_file,
                        const FirmwareImage* image,
                        int is_only_vblock) {
   int fd;
   int success = 1;
   uint8_t* firmware_blob;
   uint64_t blob_len;
 
   if (!image)
     return 0;
-  if (-1 == (fd = creat(input_file, S_IRWXU))) {
+  if (-1 == (fd = creat(output_file, 0666))) {
     debug("Couldn't open file for writing.\n");
     return 0;
   }
 
   firmware_blob = GetFirmwareBlob(image, &blob_len);
   if (!firmware_blob) {
     debug("Couldn't create firmware blob from FirmwareImage.\n");
     return 0;
   }
   if (!is_only_vblock) {
     if (blob_len != write(fd, firmware_blob, blob_len)) {
-      debug("Couldn't write Firmware Image to file: %s\n", input_file);
+      debug("Couldn't write Firmware Image to file: %s\n", output_file);
       success = 0;
     }
   } else {
     /* Exclude the firmware_data. */
     int vblock_len = blob_len - image->firmware_len;
     if (vblock_len != write(fd, firmware_blob, vblock_len)) {
       debug("Couldn't write Firmware Image verifcation block to file: %s\n",
-            input_file);
+            output_file);
       success = 0;
     }
   }
   Free(firmware_blob);
   close(fd);
   return success;
 }
 
 void PrintFirmwareImage(const FirmwareImage* image) {
   if (!image)
@@ skipping 171 matching lines @@
     Free(firmware_buf);
     return 0;
   }
   image->firmware_signature = (uint8_t*) Malloc(signature_len);
   Memcpy(image->firmware_signature, firmware_signature, signature_len);
   Free(firmware_signature);
   Free(firmware_buf);
   Free(preamble_blob);
   return 1;
 }