Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 235021: Add another Worker suppression for valgrind. (Closed)

Created:
11 years, 3 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan, dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, dank, pam+watch_chromium.org
Visibility:
Public.

Description

Add another Worker suppression for valgrind. BUG=23018 TEST=none TBR=dank Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27175

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +15 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Dmitry Titov
11 years, 3 months ago (2009-09-25 06:48:02 UTC) #1
not_the_right_dank
I'm on vacation, can you have stuart or jhawkins review? On Thu, Sep 24, 2009 ...
11 years, 3 months ago (2009-09-25 14:24:37 UTC) #2
stuartmorgan
LGTM http://codereview.chromium.org/235021/diff/2001/3001 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/235021/diff/2001/3001#newcode1066 Line 1066: fun:main I would omit these last two ...
11 years, 3 months ago (2009-09-25 16:27:28 UTC) #3
Dmitry Titov
11 years, 3 months ago (2009-09-25 20:07:26 UTC) #4
removed those frames as part of http://codereview.chromium.org/235020 (since
this one was submitted TBR)

Powered by Google App Engine
This is Rietveld 408576698