Issue 235020: Combining suppressions for linux, win and mac into single file (with widening...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235020: Combining suppressions for linux, win and mac into single file (with widening... (Closed)

Created:
11 years, 3 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Combining suppressions for linux, win and mac into single file (with widening of the call stack). BUG=22923, 22932 TEST=Suppressed tests will work again, when fixed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27236

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -42 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+1 line, -24 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Titov

Follow up for your comment in http://codereview.chromium.org/245001

11 years, 3 months ago (2009-09-25 05:33:49 UTC) #1

dank

this file isn't for windows suppressions yet :-) lgtm but rather than removing the _Znwj ...

11 years, 3 months ago (2009-09-25 14:22:49 UTC) #2

thanks, updated and landed.