Issue 235010: Reverting 27117.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235010: Reverting 27117. (Closed)

Created:
11 years, 3 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), Paweł Hajdan Jr., Ben Goodger (Google), tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 27117. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27124

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -1310 lines)			Patch
M	chrome/browser/sync/engine/syncapi.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download
D	chrome/browser/sync/engine/syncer_thread_pthreads.h	View	1 chunk	+0 lines, -284 lines	0 comments	Download
D	chrome/browser/sync/engine/syncer_thread_pthreads.cc	View	1 chunk	+0 lines, -578 lines	0 comments	Download
D	chrome/browser/sync/engine/syncer_thread_timed_stop.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	chrome/browser/sync/engine/syncer_thread_timed_stop.cc	View	1 chunk	+0 lines, -119 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread_unittest.cc	View	18 chunks	+56 lines, -188 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/test/sync/engine/mock_server_connection.h	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/test/sync/engine/mock_server_connection.cc	View	5 chunks	+4 lines, -18 lines	0 comments	Download
M	chrome/test/sync/engine/test_directory_setter_upper.h	View	2 chunks	+3 lines, -19 lines	0 comments	Download
M	chrome/test/sync/engine/test_directory_setter_upper.cc	View	2 chunks	+1 line, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

11 years, 3 months ago (2009-09-24 21:06:04 UTC) #2

:\ this doesn't have syncer_thread.cc whcih was part of my change.

On Thu, Sep 24, 2009 at 2:02 PM, <davemoore@chromium.org> wrote:

> Reviewers: timsteele,
>
> Description:
> Reverting 27117.
>
> Please review this at http://codereview.chromium.org/235010
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/sync/engine/syncapi.cc
>  D     chrome/browser/sync/engine/syncer_thread_pthreads.h
>  D     chrome/browser/sync/engine/syncer_thread_pthreads.cc
>  D     chrome/browser/sync/engine/syncer_thread_timed_stop.h
>  D     chrome/browser/sync/engine/syncer_thread_timed_stop.cc
>  M     chrome/browser/sync/engine/syncer_thread_unittest.cc
>  M     chrome/chrome.gyp
>  M     chrome/common/chrome_switches.h
>  M     chrome/common/chrome_switches.cc
>  M     chrome/test/sync/engine/mock_server_connection.h
>  M     chrome/test/sync/engine/mock_server_connection.cc
>  M     chrome/test/sync/engine/test_directory_setter_upper.h
>  M     chrome/test/sync/engine/test_directory_setter_upper.cc
>
>
>

Expand Messages | Collapse Messages