Disable the json_schema_unittest since it crashes after a WebKit deps roll....

Disable the json_schema_unittest since it crashes after a WebKit deps roll.

TBR=nsylvain
TEST=Unit tests now work.
BUG=22971
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27144

[Erik does not do reviews, 2009-09-24 23:10:00]

http://codereview.chromium.org/231024/diff/3/1002
File chrome/renderer/extensions/json_schema_unittest.cc (right):

http://codereview.chromium.org/231024/diff/3/1002#newcode52
Line 52: #if 0
drive-by: why use #if 0 if you added DISABLED_ to all of the tests anyway?  when
you do this, it means it will be hard for us to use automated tools to notice
when tests are disabled.

[jorlow, 2009-09-24 23:11:55]

http://codereview.chromium.org/231024/diff/3/1002
File chrome/renderer/extensions/json_schema_unittest.cc (right):

http://codereview.chromium.org/231024/diff/3/1002#newcode52
Line 52: #if 0
On 2009/09/24 23:10:00, Erik Kay wrote:
> drive-by: why use #if 0 if you added DISABLED_ to all of the tests anyway? 
when
> you do this, it means it will be hard for us to use automated tools to notice
> when tests are disabled.

The #if 0 was necessary because it crashed (not just failed).  The DISABLED_'s
are not.  I tried the DISABLED_'s first to double check and it didn't work.  Now
that I think about it, I should probably change back all the DISABLED_'s.

[Erik does not do reviews, 2009-09-24 23:21:08]

On Thu, Sep 24, 2009 at 4:11 PM,  <jorlow@chromium.org> wrote:
>
> http://codereview.chromium.org/231024/diff/3/1002
> File chrome/renderer/extensions/json_schema_unittest.cc (right):
>
> http://codereview.chromium.org/231024/diff/3/1002#newcode52
> Line 52: #if 0
> On 2009/09/24 23:10:00, Erik Kay wrote:
>>
>> drive-by: why use #if 0 if you added DISABLED_ to all of the tests
>
> anyway? =A0when
>>
>> you do this, it means it will be hard for us to use automated tools to
>
> notice
>>
>> when tests are disabled.
>
> The #if 0 was necessary because it crashed (not just failed). =A0The
> DISABLED_'s are not. =A0I tried the DISABLED_'s first to double check and
> it didn't work. =A0Now that I think about it, I should probably change
> back all the DISABLED_'s.

I don't understand.  DISABLED tests aren't run, so why would they crash?

Erik

>
> http://codereview.chromium.org/231024
>