Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/renderer/extensions/json_schema_unittest.cc

Issue 231024: Disable the json_schema_unittest since it crashes after a WebKit deps roll.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Name: svn:eol-style
+ LF
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "app/resource_bundle.h" 5 #include "app/resource_bundle.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
10 #include "chrome/test/v8_unit_test.h" 10 #include "chrome/test/v8_unit_test.h"
(...skipping 30 matching lines...) Expand all
41 FilePath test_js_file_path; 41 FilePath test_js_file_path;
42 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_js_file_path)); 42 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_js_file_path));
43 test_js_file_path = test_js_file_path.AppendASCII("extensions"); 43 test_js_file_path = test_js_file_path.AppendASCII("extensions");
44 test_js_file_path = test_js_file_path.AppendASCII(kJsonSchemaTest); 44 test_js_file_path = test_js_file_path.AppendASCII(kJsonSchemaTest);
45 std::string test_js; 45 std::string test_js;
46 ASSERT_TRUE(file_util::ReadFileToString(test_js_file_path, &test_js)); 46 ASSERT_TRUE(file_util::ReadFileToString(test_js_file_path, &test_js));
47 ExecuteScriptInContext(test_js, kJsonSchemaTest); 47 ExecuteScriptInContext(test_js, kJsonSchemaTest);
48 } 48 }
49 }; 49 };
50 50
51 TEST_F(JsonSchemaTest, TestFormatError) { 51 // TODO: Re-enable this test! http://crbug.com/22971
52 #if 0
Erik does not do reviews 2009/09/24 23:10:00 drive-by: why use #if 0 if you added DISABLED_ to
jorlow 2009/09/24 23:11:55 The #if 0 was necessary because it crashed (not ju
53 TEST_F(JsonSchemaTest, DISABLED_TestFormatError) {
52 TestFunction("testFormatError"); 54 TestFunction("testFormatError");
53 } 55 }
54 56
55 TEST_F(JsonSchemaTest, TestComplex) { 57 TEST_F(JsonSchemaTest, DISABLED_TestComplex) {
56 TestFunction("testComplex"); 58 TestFunction("testComplex");
57 } 59 }
58 60
59 TEST_F(JsonSchemaTest, TestEnum) { 61 TEST_F(JsonSchemaTest, DISABLED_TestEnum) {
60 TestFunction("testEnum"); 62 TestFunction("testEnum");
61 } 63 }
62 64
63 TEST_F(JsonSchemaTest, TestExtends) { 65 TEST_F(JsonSchemaTest, DISABLED_TestExtends) {
64 TestFunction("testExtends"); 66 TestFunction("testExtends");
65 } 67 }
66 68
67 TEST_F(JsonSchemaTest, TestObject) { 69 TEST_F(JsonSchemaTest, DISABLED_TestObject) {
68 TestFunction("testObject"); 70 TestFunction("testObject");
69 } 71 }
70 72
71 TEST_F(JsonSchemaTest, TestArrayTuple) { 73 TEST_F(JsonSchemaTest, DISABLED_TestArrayTuple) {
72 TestFunction("testArrayTuple"); 74 TestFunction("testArrayTuple");
73 } 75 }
74 76
75 TEST_F(JsonSchemaTest, TestArrayNonTuple) { 77 TEST_F(JsonSchemaTest, DISABLED_TestArrayNonTuple) {
76 TestFunction("testArrayNonTuple"); 78 TestFunction("testArrayNonTuple");
77 } 79 }
78 80
79 TEST_F(JsonSchemaTest, TestString) { 81 TEST_F(JsonSchemaTest, DISABLED_TestString) {
80 TestFunction("testString"); 82 TestFunction("testString");
81 } 83 }
82 84
83 TEST_F(JsonSchemaTest, TestNumber) { 85 TEST_F(JsonSchemaTest, DISABLED_TestNumber) {
84 TestFunction("testNumber"); 86 TestFunction("testNumber");
85 } 87 }
86 88
87 TEST_F(JsonSchemaTest, TestType) { 89 TEST_F(JsonSchemaTest, DISABLED_TestType) {
88 TestFunction("testType"); 90 TestFunction("testType");
89 } 91 }
90 92
91 TEST_F(JsonSchemaTest, TestTypeReference) { 93 TEST_F(JsonSchemaTest, DISABLED_TestTypeReference) {
92 TestFunction("testTypeReference"); 94 TestFunction("testTypeReference");
93 } 95 }
94 96 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698