Issue 2280003: Use IPC to wait for download in DownloadTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2280003: Use IPC to wait for download in DownloadTest. (Closed)

Created:
10 years, 7 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, brettw-cc_chromium.org, Paul Godavari, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail.google.com/chromium.git

Visibility:
Public.

Description

Use IPC to wait for download in DownloadTest. Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests. Chrome OS shows the file browsing UI instead of the download shelf, so we check for that. This should decrease flakiness of download tests. TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab* BUG=43066

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -79 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		5 chunks	+30 lines, -7 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.h	View		2 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View	1	6 chunks	+38 lines, -4 lines	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_encoding_uitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_uitest.cc	View		12 chunks	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/download/save_page_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/multipart_uitest.cc	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/common/notification_type.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/test/automation/browser_proxy.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/automation/browser_proxy.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download