chrome/browser/download/save_page_uitest.cc - Issue 2280003: Use IPC to wait for download in DownloadTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_uitest.cc

Issue 2280003: Use IPC to wait for download in DownloadTest. (Closed) Base URL: git://codf21.jail.google.com/chromium.git

Patch Set: Fix compile error. Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/save_page_uitest.cc

diff --git a/chrome/browser/download/save_page_uitest.cc b/chrome/browser/download/save_page_uitest.cc

index 07fd78c4c39f2dc23e8654db9b3cd8a3f1762bf6..c9de08b0c293ea20ad0901c31e258d42fff809d3 100644

--- a/chrome/browser/download/save_page_uitest.cc

+++ b/chrome/browser/download/save_page_uitest.cc

@@ -84,7 +84,7 @@ TEST_F(SavePageTest, CleanFilenameFromPageTitle) {

ASSERT_TRUE(browser.get());

automation()->SavePackageShouldPromptUser(false);

EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE));

- EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));

+ EXPECT_TRUE(browser->WaitForDownloadShelfVisibilityChange(true));

automation()->SavePackageShouldPromptUser(true);

CheckFile(full_file_name, file_name);