chrome/browser/download/save_page_uitest.cc - Issue 2280003: Use IPC to wait for download in DownloadTest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/download/save_page_uitest.cc

Issue 2280003: Use IPC to wait for download in DownloadTest. (Closed) Base URL: git://codf21.jail.google.com/chromium.git

Patch Set: Fix compile error. Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/download/download_uitest.cc ('k') | chrome/browser/history/multipart_uitest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/file_util.h"	5 #include "base/file_util.h"

6 #include "base/path_service.h"	6 #include "base/path_service.h"

7 #include "base/platform_thread.h"	7 #include "base/platform_thread.h"

8 #include "base/string_util.h"	8 #include "base/string_util.h"

9 #include "base/test/test_file_util.h"	9 #include "base/test/test_file_util.h"

10 #include "chrome/app/chrome_dll_resource.h"	10 #include "chrome/app/chrome_dll_resource.h"

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 FilePath(kTestDir).Append(file_name));	77 FilePath(kTestDir).Append(file_name));

78 scoped_refptr<TabProxy> tab(GetActiveTab());	78 scoped_refptr<TabProxy> tab(GetActiveTab());

79 ASSERT_TRUE(tab.get());	79 ASSERT_TRUE(tab.get());

80 ASSERT_TRUE(tab->NavigateToURL(url));	80 ASSERT_TRUE(tab->NavigateToURL(url));

81 WaitUntilTabCount(1);	81 WaitUntilTabCount(1);

82	82

83 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));	83 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));

84 ASSERT_TRUE(browser.get());	84 ASSERT_TRUE(browser.get());

85 automation()->SavePackageShouldPromptUser(false);	85 automation()->SavePackageShouldPromptUser(false);

86 EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE));	86 EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE));

87 EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));	87 EXPECT_TRUE(browser->WaitForDownloadShelfVisibilityChange(true));

88 automation()->SavePackageShouldPromptUser(true);	88 automation()->SavePackageShouldPromptUser(true);

89	89

90 CheckFile(full_file_name, file_name);	90 CheckFile(full_file_name, file_name);

91 EXPECT_TRUE(file_util::DieFileDie(full_file_name, false));	91 EXPECT_TRUE(file_util::DieFileDie(full_file_name, false));

92 EXPECT_TRUE(file_util::DieFileDie(dir, true));	92 EXPECT_TRUE(file_util::DieFileDie(dir, true));

93 }	93 }

94 #endif	94 #endif

OLD	NEW