Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 223030: Add the stack signature of a small memory leak found in SessionHistoryTest.Hi... (Closed)

Created:
11 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Add the stack signature of a small memory leak found in SessionHistoryTest.HistorySearchXSS to the valgrind suppression list. BUG=22984 TEST=Valgrind bot does not report this leak any more when running SessionHistoryTest.HistorySearchXSS TBR=dank Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years, 3 months ago (2009-09-25 00:24:46 UTC) #1
not_the_right_dank
11 years, 3 months ago (2009-09-25 04:19:44 UTC) #2
LGTM

On Thu, Sep 24, 2009 at 5:24 PM,  <jshin@chromium.org> wrote:
>
> Reviewers: dank,
>
> Description:
> Add the stack signature of a small memory leak found in
> SessionHistoryTest.HistorySearchXSS to the valgrind suppression list.
>
> BUG=3D22984
> TEST=3DValgrind bot does not report this leak any more when running
> SessionHistoryTest.HistorySearchXSS
> TBR=3Ddank
>
> Please review this at http://codereview.chromium.org/223030
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- tools/valgrind/memcheck/suppressions.txt =A0 =A0(revision 27116)
> +++ tools/valgrind/memcheck/suppressions.txt =A0 =A0(working copy)
> @@ -1319,3 +1319,25 @@
>
> =A0fun:_ZN2v88internal6InvokeEbNS0_6HandleINS0_10JSFunctionEEENS1_INS0_6O=
bjectEEEiPPPS4_Pb
>
> =A0fun:_ZN2v88internal9Execution4CallENS0_6HandleINS0_10JSFunctionEEENS2_=
INS0_6ObjectEEEiPPPS5_Pb
> =A0}
> +{
> + =A0 bug_22984
> + =A0 Memcheck:Leak
> + =A0 fun:_Znwj
> +
> fun:_ZN27ScopedRunnableMethodFactoryI12SpellCheckerE17NewRunnableMethodIM=
S0_FvvEEEP4TaskT_
> +
> fun:_ZN12SpellChecker18OnURLFetchCompleteEPK10URLFetcherRK4GURLRK16URLReq=
uestStatusiRKSt6vectorISsSaISsEERKSs
> + =A0 fun:_ZN10URLFetcher4Core21OnCompletedURLRequestERK16URLRequestStatu=
s
> +
> fun:_Z16DispatchToMethodIN10URLFetcher4CoreEMS1_FvRK16URLRequestStatusES2=
_EvPT_T0_RK6Tuple1IT1_E
> +
> fun:_ZN14RunnableMethodIN10URLFetcher4CoreEMS1_FvRK16URLRequestStatusE6Tu=
ple1IS2_EE3RunEv
> + =A0 fun:_ZN11MessageLoop7RunTaskEP4Task
> + =A0 fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
> + =A0 fun:_ZN11MessageLoop6DoWorkEv
> + =A0 fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE
> + =A0 fun:_ZN11MessageLoop11RunInternalEv
> + =A0 fun:_ZN11MessageLoop10RunHandlerEv
> + =A0 fun:_ZN11MessageLoop3RunEv
> + =A0 fun:_ZN4base6Thread3RunEP11MessageLoop
> + =A0 fun:_ZN4base6Thread10ThreadMainEv
> + =A0 fun:_Z10ThreadFuncPv
> + =A0 fun:start_thread
> + =A0 fun:clone
> +}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698