Issue 216044: Implement fixes requested in review http://codereview.chromium.org/215039

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216044: Implement fixes requested in review http://codereview.chromium.org/215039 (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement fixes requested in review http://codereview.chromium.org/215039 TBR=nsylvain BUG=none TEST=none

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	tests/gclient_test.py	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 3 months ago (2009-09-22 14:03:56 UTC) #2

lg

On Tue, Sep 22, 2009 at 6:36 AM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Implement fixes requested in review http://codereview.chromium.org/215039
>
> TBR=nsylvain
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/216044
>
> Affected files:
>  M tests/gclient_test.py
>
>
> Index: tests/gclient_test.py
> diff --git a/tests/gclient_test.py b/tests/gclient_test.py
> index
>
479add60b82a97f4202cd4dafccd51eecedfa4d4..aa341f3cb4f84923f7586350ad5b7320bc2e8479
> 100644
> --- a/tests/gclient_test.py
> +++ b/tests/gclient_test.py
> @@ -1092,8 +1092,8 @@ class SCMWrapperTestCase(GClientBaseTestCase):
>     base_path = os.path.join(self.root_dir, self.relpath)
>     gclient.os.path.isdir(base_path).AndReturn(True)
>     gclient_scm.CaptureSVNStatus(base_path).AndReturn([])
> -    gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
> base_path,
> -                                     mox.IgnoreArg())
> +    gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
> +                                     base_path, mox.IgnoreArg())
>
>     self.mox.ReplayAll()
>     scm = self._scm_wrapper(url=self.url, root_dir=self.root_dir,
> @@ -1118,8 +1118,8 @@ class SCMWrapperTestCase(GClientBaseTestCase):
>     gclient_scm.os.path.exists(file_path2).AndReturn(True)
>     gclient_scm.os.path.isfile(file_path2).AndReturn(True)
>     gclient_scm.os.remove(file_path2)
> -    gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
> base_path,
> -                                     mox.IgnoreArg())
> +    gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
> +                                     base_path, mox.IgnoreArg())
>     print(os.path.join(base_path, 'a'))
>     print(os.path.join(base_path, 'b'))
>
> @@ -1142,7 +1142,6 @@ class SCMWrapperTestCase(GClientBaseTestCase):
>     gclient_scm.os.path.exists(file_path).AndReturn(True)
>     gclient_scm.os.path.isfile(file_path).AndReturn(False)
>     gclient_scm.os.path.isdir(file_path).AndReturn(True)
> -    #gclient_scm.os.remove(file_path)
>     gclient_utils.RemoveDirectory(file_path)
>     file_list1 = []
>     gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
> base_path,
>
>
>

Expand Messages | Collapse Messages