Issue 215039: Fix gclient unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215039: Fix gclient unittests. (Closed)

Created:
11 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix gclient unittests. BUG=none TEST=unittests

Patch Set 1 #

Total comments: 4

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -11 lines)			Patch
	M	tests/gclient_test.py	View		4 chunks	+23 lines, -11 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 3 months ago (2009-09-21 22:30:43 UTC) #2

http://codereview.chromium.org/215039/diff/1/2
File tests/gclient_test.py (right):

http://codereview.chromium.org/215039/diff/1/2#newcode1095
Line 1095: gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
base_path,
80 chars

http://codereview.chromium.org/215039/diff/1/2#newcode1121
Line 1121: gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
base_path,
80 chars

http://codereview.chromium.org/215039/diff/1/2#newcode1145
Line 1145: #gclient_scm.os.remove(file_path)
why?

http://codereview.chromium.org/215039/diff/1/2#newcode1148
Line 1148: gclient_scm.RunSVNAndGetFileList(['update', '--revision', 'BASE'],
base_path,
80 chars

Expand Messages | Collapse Messages