Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 21347: Make the debugger completely unload when the debug event listener is unregist... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the debugger completely unload when the debug event listener is unregistered. Added a number of handle scopes to the debugger code to keep handles local to the function using them. Fixed SetDebugEventListener to actually unregister when passed a NULL pointer. Previously this NULL pointer was wrapped in a Proxy. BUG=1242702 Committed: http://code.google.com/p/v8/source/detail?r=1269

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -5 lines) Patch
M src/api.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/debug.h View 4 chunks +4 lines, -0 lines 0 comments Download
M src/debug.cc View 1 12 chunks +48 lines, -0 lines 0 comments Download
M src/debug-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/debug-ia32.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 37 chunks +154 lines, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-recursive.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-13 12:19:49 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/21347/diff/1/6 File src/debug.cc (right): http://codereview.chromium.org/21347/diff/1/6#newcode370 Line 370: // DebugInfo wvwn though the code is ...
11 years, 10 months ago (2009-02-13 12:31:15 UTC) #2
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-13 12:35:42 UTC) #3
http://codereview.chromium.org/21347/diff/1/6
File src/debug.cc (right):

http://codereview.chromium.org/21347/diff/1/6#newcode370
Line 370: // DebugInfo wvwn though the code is patched back to the non break
point state.
On 2009/02/13 12:31:15, Mads Ager wrote:
> Keyboard off by one: wvwn -> even.  :-)

Done.

http://codereview.chromium.org/21347/diff/1/6#newcode605
Line 605: // Get rid of all break pointa and related information.
On 2009/02/13 12:31:15, Mads Ager wrote:
> pointa -> points

Done.

Powered by Google App Engine
This is Rietveld 408576698